#19652 Fix chained alias this.

[ghost]

Culprit 4d4cd92

[ghost]

It looks good to merge as is but this is a regression fix so your PR can go in stable although it's not guaranteed that there'll be a 2084.2. Also you don't refer to any issue, the dlang bot should have tell you this. There should be an issue because the bug is delivered in 2084.0.

[Geod24]

@look-at-me : Thanks for the quick fix. Could you reword the commit to comply to our style, which, as @Basile-z mentioned, will also trigger dlang bot and the various automation.
It should be: "Fix issue 19652 - alias this chain no longer works" (or any other title you see as meaningful)

Adding a comment to the code, such as "// We need to check for alias this recursively" (over the first check) could also help prevent people doing the same mistake in the future.

[Geod24]

Can you also add the following test in runnable:

auto otherTest(inout ref Base block) @nogc { assert(0); }
auto otherTest(inout ref A block) @nogc {}
// ...
otherTest(*thingie);

To make sure A is picked over Base ?

[dlang-bot]

Thanks for your pull request and interest in making D better, @look-at-me! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19652	regression	[REG2.084] alias this chain no longer works

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9334"

[wilzbach]

Your PR doesn't reference any Bugzilla issue.

Please follow this guide to reference your Bugzilla issue in your commit message. Thanks!

[ghost]

Fix Issue 19652 Fix chained alias this.

My commit message references an issue

https://issues.dlang.org/show_bug.cgi?id=19652

[wilzbach]

My commit message references an issue

Looks like there was just a (temporary?) problem with the dlang-bot. It now detects your issue (:
So in accordance to:

I rebased your PR and re-targeted stable.

Tests have been added