Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 12001 - __traits(isSame) does not work with the basic types #9356

Merged
merged 1 commit into from Feb 13, 2019
Merged

fix issue 12001 - __traits(isSame) does not work with the basic types #9356

merged 1 commit into from Feb 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2019

Very surprisingly not already fixed. As rationale, I quote the reporter:

...It really should be true ... to be useful in generic code.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
12001 normal __traits(isSame) does not work with the basic types

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9356"

@ghost
Copy link
Author

ghost commented Feb 13, 2019

Sorry I didn't see the failure after running locally the test, So not ready yet.

@thewilsonator
Copy link
Contributor

OK ping me when it is.

@ghost
Copy link
Author

ghost commented Feb 13, 2019

Ping @thewilsonator this is working now. It was a getType() vs isType() problem, the former always falls back to something, which i should know...

@thewilsonator
Copy link
Contributor

Done.

@dlang-bot dlang-bot merged commit b8cd82a into dlang:master Feb 13, 2019
@ghost ghost deleted the issue-12001 branch February 13, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants