Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19523 - "undefined identifier" causes DMD crash #9360

Merged
merged 1 commit into from Feb 14, 2019
Merged

fix issue 19523 - "undefined identifier" causes DMD crash #9360

merged 1 commit into from Feb 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19523 regression "undefined identifier" causes DMD crash

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9360"

@ghost
Copy link
Author

ghost commented Feb 14, 2019

I was not able to run the tests locally on stable although the same patch worked on master so let's see...

@wilzbach
Copy link
Member

As @Basile-z was a few seconds faster than me in finding the problem with excel-d, here's the link for others: symmetryinvestments/excel-d#63

@dlang-bot dlang-bot merged commit 3887c00 into dlang:stable Feb 14, 2019
TEST_OUTPUT:
---
fail_compilation/b19523.d(12): Error: undefined identifier `SomeStruct`
fail_compilation/b19523.d(13): Error: function `b19523.foo(int delegate() arg)` is not callable using argument types `(_error_)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should _error_ really appear in the user-facing output?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say ideally not.

@ghost ghost deleted the issue-19523 branch March 31, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants