Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 17290 - DMD crash due to circular reference in function return type #9403

Merged
merged 1 commit into from Mar 2, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2019

The fix is actually a generalization of what's been done in #9365.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
17290 normal DMD crash due to circular reference in function return type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9403"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

src/dmd/expressionsem.d Outdated Show resolved Hide resolved
@thewilsonator
Copy link
Contributor

Test runnable/gdb15729.sh failed. The logged output:
warning: Error disabling address space randomization: Operation not permitted
test_results/runnable/gdb15729.gdb:2: Error in sourced command file:
During startup program exited normally.
==============================

Huh?

@ghost
Copy link
Author

ghost commented Mar 2, 2019

Unfortunately I don't have the privileges to relaunch the CircleCI tests myself, can you @thewilsonator ?

@thewilsonator
Copy link
Contributor

Magic! it appears to have fixed itself.

@dlang-bot dlang-bot merged commit 22438dd into dlang:master Mar 2, 2019
@ghost ghost deleted the issue-17290 branch March 2, 2019 11:21
@ghost
Copy link
Author

ghost commented Mar 2, 2019

No magic here, the problem in #9404

wilzbach pushed a commit to wilzbach/dmd that referenced this pull request Mar 11, 2019
fix issue 17290 - DMD crash due to circular reference in function return type
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants