-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ small struct test #9411
C++ small struct test #9411
Conversation
|
Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9411" |
|
Don't jump to conclusions; I expect this to fail CI, and hopefully motivate someone to fix it ;) |
e639eb5 to
4f66fea
Compare
4f66fea to
5df26dc
Compare
|
I don't understand. If there's a bug that needs fixing, and this PR is not fixing, shouldn't it be in bugzilla instead? |
|
The bugzilla issue has been sitting there for months... which means I've been twiddling my thumbs for months. Bad-codegen bugs are really bad. |
|
I was also interested to see the matrix of targets where this fails. |
|
I see you added the bugzilla reference after I posted that, thank you. The Bugzilla should also be in the PR title, something like "Test case for Issue 19563 extern(C++) Incorrect ABI passing small struct" |
This unittest shouldn't fail, but there seems to be an ABI issue with small struct's, which needs to be fixed.
https://issues.dlang.org/show_bug.cgi?id=19563