Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ small struct test #9411

Closed
wants to merge 1 commit into from
Closed

Conversation

TurkeyMan
Copy link
Contributor

@TurkeyMan TurkeyMan commented Mar 4, 2019

This unittest shouldn't fail, but there seems to be an ABI issue with small struct's, which needs to be fixed.

https://issues.dlang.org/show_bug.cgi?id=19563

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9411"

@TurkeyMan
Copy link
Contributor Author

Don't jump to conclusions; I expect this to fail CI, and hopefully motivate someone to fix it ;)

@TurkeyMan TurkeyMan force-pushed the cpp_small_struct branch 2 times, most recently from e639eb5 to 4f66fea Compare March 4, 2019 03:26
@WalterBright
Copy link
Member

I don't understand. If there's a bug that needs fixing, and this PR is not fixing, shouldn't it be in bugzilla instead?

@TurkeyMan
Copy link
Contributor Author

TurkeyMan commented Mar 4, 2019

The bugzilla issue has been sitting there for months... which means I've been twiddling my thumbs for months.
I figured a working unit test would be more helpful. Anyone can checkout the PR and they have a repro ready to go.

Bad-codegen bugs are really bad.

@TurkeyMan
Copy link
Contributor Author

TurkeyMan commented Mar 4, 2019

I was also interested to see the matrix of targets where this fails.
I thought it was only linux 64...

@WalterBright
Copy link
Member

I see you added the bugzilla reference after I posted that, thank you. The Bugzilla should also be in the PR title, something like "Test case for Issue 19563 extern(C++) Incorrect ABI passing small struct"

@ghost
Copy link

ghost commented Mar 4, 2019

#9295

@TurkeyMan TurkeyMan closed this Jun 5, 2019
@TurkeyMan TurkeyMan deleted the cpp_small_struct branch June 5, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants