Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19717 - case of segfault due to undetected forward reference #9412

Merged
merged 1 commit into from Mar 4, 2019
Merged

fix issue 19717 - case of segfault due to undetected forward reference #9412

merged 1 commit into from Mar 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 4, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19717 normal case of segfault due to undetected forward reference

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9412"

@dlang-bot dlang-bot merged commit e7cac4e into dlang:master Mar 4, 2019
@ghost ghost deleted the issue-19717 branch March 4, 2019 09:14
wilzbach pushed a commit to wilzbach/dmd that referenced this pull request Mar 11, 2019
fix issue 19717 -  case of segfault due to undetected forward reference
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
ibuclaw added a commit to ibuclaw/dmd that referenced this pull request Jun 16, 2019
ibuclaw added a commit to ibuclaw/dmd that referenced this pull request Jun 16, 2019
dlang-bot added a commit that referenced this pull request Jun 16, 2019
Add another test that used to SEGV before #9412
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
ibuclaw added a commit to ibuclaw/dmd that referenced this pull request Jun 16, 2019
ibuclaw added a commit to ibuclaw/dmd that referenced this pull request Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants