Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19755 - Compiler crash #9470

Merged
merged 1 commit into from Mar 20, 2019
Merged

fix issue 19755 - Compiler crash #9470

merged 1 commit into from Mar 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2019

Just an easy to fix unsafe access

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19755 normal Compiler crash

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9470"

@ghost
Copy link
Author

ghost commented Mar 20, 2019

@thewilsonator, sorry I had to force push, auto-merge label needed again.

@thewilsonator
Copy link
Contributor

Done.

@dlang-bot dlang-bot merged commit dced499 into dlang:stable Mar 20, 2019
@UplinkCoder
Copy link
Member

There seems to be another bug here.
Thunk self should NOT be rewritten to Thunk!int self

@UplinkCoder
Copy link
Member

ping @thewilsonator

@thewilsonator
Copy link
Contributor

Hmm, yeah. That should error on use of uninstantiated template.

@ghost ghost deleted the issue-19755 branch March 20, 2019 17:55
@ghost
Copy link
Author

ghost commented Mar 20, 2019

You mean that it's a hdrgen bug or a semantic one ?

@UplinkCoder
Copy link
Member

not sure; I assume it's sema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants