Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19778 - ICE when accessing empty array at compile time #9547

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Apr 3, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19778 regression ICE when accessing empty array at compile time

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9547"

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Apr 3, 2019

I cannot push this PR on top of stable because the PR that caused the regression has not made it yet to stable.

@dlang-bot dlang-bot merged commit d1425ea into dlang:master Apr 3, 2019
@WalterBright
Copy link
Member

Thanks, @RazvanN7

@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Apr 4, 2019

Don't mention it, @WalterBright .

@JinShil
Copy link
Contributor

JinShil commented Apr 30, 2019

According to a digger bisection, this PR may have introduced a regression: https://issues.dlang.org/show_bug.cgi?id=19822

@RazvanN7
Copy link
Contributor Author

PR: #9730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants