Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19804 - fails to compile with fixes size array T[1]... #9623

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Apr 16, 2019

argument

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19804 regression fails to compile with fixes size array T[1]... argument

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9623"

src/dmd/backend/cod3.d Outdated Show resolved Hide resolved
src/dmd/backend/cod3.d Outdated Show resolved Hide resolved
src/dmd/backend/cod3.d Outdated Show resolved Hide resolved
@JinShil
Copy link
Contributor

JinShil commented Apr 16, 2019

I ran a digger bisection to try to identify the PR that caused this regression. It reported #9364 That isn't very precise, but by educated guess, it appears to be #9357

@dlang-bot dlang-bot merged commit d7ab8dd into dlang:stable Apr 16, 2019
@kubo39 kubo39 deleted the bugfix-19804 branch April 16, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants