fix issue 19661 - SIGSEGV in std.traits.isFunction #9648
Conversation
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9648" |
ghost
closed this
ghost
reopened this
| @@ -374,7 +374,8 @@ extern(C++) Initializer initializerSemantic(Initializer init, Scope* sc, Type t, | |||
| sc = sc.endCTFE(); | |||
| if (i.exp.op == TOK.error) | |||
| { | |||
| return new ErrorInitializer(); | |||
| assert(cast(ErrorExp) i.exp); | |||
There was a problem hiding this comment.
This cast is useless, because ErrorExp is an extern(C++) class
There was a problem hiding this comment.
Casting it is even less correct. Again, need to find where i.exp.op was set to TOK.error.
| @@ -374,7 +374,8 @@ extern(C++) Initializer initializerSemantic(Initializer init, Scope* sc, Type t, | |||
| sc = sc.endCTFE(); | |||
| if (i.exp.op == TOK.error) | |||
| { | |||
| return new ErrorInitializer(); | |||
| assert(cast(ErrorExp) i.exp); | |||
There was a problem hiding this comment.
Casting it is even less correct. Again, need to find where i.exp.op was set to TOK.error.
ghost
closed this
ghost
deleted the
|
New fix : #9652 |
The ICE didn't happen when the imported template, isFunction, was copied in the same module as the test case. Now in both cases the same compiler error is issued (and in both cases the line information misses).