Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19833 - The member as template cannot be acquired by getMember #9723

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Apr 28, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19833 regression The member as template cannot be acquired by getMember

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9723"

test/compilable/test19833.d Show resolved Hide resolved
@kubo39 kubo39 force-pushed the bugfix-issue19833 branch from 46d20fe to 74f850e Compare April 28, 2019 19:21
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@thewilsonator thewilsonator merged commit 0e8341a into dlang:stable Apr 29, 2019
@kubo39 kubo39 deleted the bugfix-issue19833 branch April 29, 2019 10:49
kubo39 added a commit to kubo39/dmd that referenced this pull request May 12, 2019
The fix in dlang#9723 does not care about OverExp.
@kubo39 kubo39 mentioned this pull request May 12, 2019
kubo39 added a commit to kubo39/dmd that referenced this pull request May 12, 2019
The fix in dlang#9723 does not care about OverExp.
kubo39 added a commit to kubo39/dmd that referenced this pull request May 12, 2019
The fix in dlang#9723 does not care about OverExp.
kubo39 added a commit to kubo39/dmd that referenced this pull request May 12, 2019
The fix in dlang#9723 does not care about OverExp.
kubo39 added a commit to kubo39/dmd that referenced this pull request May 12, 2019
The fix in dlang#9723 does not care about OverExp.
kubo39 added a commit to kubo39/dmd that referenced this pull request May 14, 2019
The fix in dlang#9723 does not care about OverExp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants