Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup 19774 #9725

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Followup 19774 #9725

merged 1 commit into from
Apr 29, 2019

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Apr 29, 2019

The fix in #9696 does not take into account situations where multiple declarations are needed for the return statement (that is the case of opDollar: a temporary for the function call + a temporary for opDollar). This patch fixes that.

@RazvanN7 RazvanN7 requested a review from ibuclaw as a code owner April 29, 2019 07:26
@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 29, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19774 regression wrong code caused by opIndex

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9725"

@RazvanN7 RazvanN7 changed the base branch from master to stable April 29, 2019 07:27
@RazvanN7
Copy link
Contributor Author

I've put the auto-merge tag since 2 reviewers approved the PR and it seems that stable will soon be merged with master and #9696 is already going to get in.

@dlang-bot dlang-bot merged commit 9b423d6 into dlang:stable Apr 29, 2019
@9il
Copy link
Member

9il commented Apr 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants