Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19822 - 2.086 regression wrt. union initializers #9730

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Apr 30, 2019

The array checks should be grouped together as the initial condition was:

 if (structlit &&
    ((e.op == TOK.void_) ||
     (e.op == TOK.arrayLiteral && e.type.ty == Tsarray && isEntirelyVoid((cast(ArrayLiteralExp)e).elements)) ||
     (e.op == TOK.structLiteral && isEntirelyVoid((cast(StructLiteralExp)e).elements))))

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 30, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19822 regression 2.086 regression wrt. union initializers

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9730"

@RazvanN7 RazvanN7 changed the base branch from master to stable April 30, 2019 08:02
@RazvanN7 RazvanN7 added the Severity:Regression PRs that fix regressions label Apr 30, 2019
@thewilsonator thewilsonator added Merge:auto-merge Review:stable-priority A regression fix to stable that should receive higher priority labels Apr 30, 2019
@RazvanN7 RazvanN7 closed this Apr 30, 2019
@RazvanN7 RazvanN7 reopened this Apr 30, 2019
@dlang-bot dlang-bot merged commit e971775 into dlang:stable Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:auto-merge Review:stable-priority A regression fix to stable that should receive higher priority Severity:Bug Fix Severity:Regression PRs that fix regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants