Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19871 - Copy constructor rejects valid code if default construction is disabled #9792

Merged
merged 1 commit into from
May 14, 2019

Conversation

RazvanN7
Copy link
Contributor

The initial idea was that when the compiler searches for copy constructors it should stop when it has found one, however, it should also check if the user has defined an rvalue normal constructor. The patch makes it so that the search for copy constructors does not stop when a copy constructor was found.

@dlang-bot
Copy link
Contributor

dlang-bot commented May 14, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19871 regression Copy constructor rejects valid code if default construction is disabled

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9792"

@RazvanN7 RazvanN7 changed the base branch from master to stable May 14, 2019 15:22
@dlang-bot dlang-bot merged commit 2f592d5 into dlang:stable May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants