fix Issue 19890 - ICE: Segmentation fault with negative array size

[ibuclaw]

Rather than tbn.isintegral() || tbn.isfloating(), check tbn.isTypeBasic() instead, so that void is included in the overflow check.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19890	critical	ICE: Segmentation fault with negative array size

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

To target stable perform these two steps:

1. Rebase your branch to upstream/stable:

git rebase --onto upstream/stable upstream/master

2. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9840"

[ibuclaw]

I've just removed the TEST_OUTPUT, but left the comment. So it's only checking that the compiler exits with a graceful error code.