Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove backend os.d" #9880

Merged
merged 1 commit into from
May 25, 2019
Merged

Revert "Remove backend os.d" #9880

merged 1 commit into from
May 25, 2019

Conversation

WalterBright
Copy link
Member

Reverts #9864

Please stop changing the back end. It thoroughly messes up DMC++.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9880"

@adamdruppe
Copy link
Contributor

@WalterBright do you think we can add dmc to the public test somehow? Then other people would realize what is going on here and can save you this trouble.

@WalterBright
Copy link
Member Author

It's more than just compiling DMC++. There's a whole test suite for it. As I'm sure you're aware, C++ is a tricky language to compile, and the compiler is fragile because of it. I don't think it makes much sense for D to check in the code for it, as nobody in the D community is interested in it.

I don't mind if people create PRs for the backend. But I do mind if both the people creating PRs and the people approving and pulling them have no expertise with it and even less interest. Each of us has different areas of expertise, and to get a PR merged needs at least one of the involved parties to have expertise with it.

For example, I have no expertise in installation or test framework issues, and defer decisions about them to people who have it. I defer to Jacob regarding issues with the ObjC support. And so on.

@dlang-bot dlang-bot merged commit 0105aae into master May 25, 2019
@Herringway
Copy link
Contributor

A single person only has so much mental bandwidth. You really should lighten your burden.

@adamdruppe
Copy link
Contributor

Well, there's gotta just be some way to make it clear to people that these things are ok for dmd, but have side effects on dmc.

I guess you could institute a policy of nobody merges backend stuff without your ok.

@Geod24 Geod24 deleted the revert-9864-backend-kill-os branch May 26, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants