fix Issue 19922/19923 - ICE: using typeid() or .classinfo without TypeInfo_Class #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9941" |
| @@ -4974,6 +4974,11 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
| error(exp.loc, "Runtime type information is not supported for `extern(C++)` classes"); | |||
| e = new ErrorExp(); | |||
| } | |||
| else if (!Type.typeinfoclass) | |||
| { | |||
| error(exp.loc, "`object.TypeInfo_Class` could not be found, but is implicitly used"); | |||
There was a problem hiding this comment.
Perhaps add by typeid to the error message.
There was a problem hiding this comment.
It is consistent with the error message in no_TypeInfo.d, which the test is:
void test()
{
int i;
auto ti = typeid(i);
}
Which is identical to this, except getting the typeid of an int instead.
| assert(Type.typeinfoclass); | ||
| if (!Type.typeinfoclass) | ||
| { | ||
| error(e.loc, "`object.TypeInfo_Class` could not be found, but is implicitly used"); |
There was a problem hiding this comment.
Perhaps add by classinfo to the error message.
JinShil
approved these changes
Jun 1, 2019
thewilsonator
approved these changes
Jun 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.