Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19584 - Illegal optimization: Shift-or -> imul #9990

Merged
merged 1 commit into from Jun 7, 2019
Merged

fix issue 19584 - Illegal optimization: Shift-or -> imul #9990

merged 1 commit into from Jun 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2019

Regression was caused by #2333. The change is simply removed because the other compilers don't optimize either, see for example.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19584 regression Illegal optimization: Shift-or -> imul

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9990"

@thewilsonator
Copy link
Contributor

cc @WalterBright

@ghost
Copy link
Author

ghost commented Jun 7, 2019

@thewilsonator there's nothing else to do there. Even LDC, the huge big backend and all the "brains" that have contributed to make it, does not optimize the operations that are involved.

Copy link
Contributor

@JinShil JinShil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to not have the regression than to have the optimization.

@WalterBright WalterBright merged commit 4fd0acc into dlang:stable Jun 7, 2019
@ghost ghost deleted the issue-19584 branch June 7, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants