Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dlang/druntime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1c95b5827012
Choose a base ref
...
head repository: dlang/druntime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 713aa0568a0b
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 31, 2015

  1. remove incorrect comment 

    - both Thread.remove and thread_suspendAll synchronize on slock
  so a double removal isn't possible
- we still set isRunning to false b/c some functions must not be called
  on a stopped thread, e.g. setPriority
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    8287001 View commit details
    Browse the repository at this point in the history

  2. fix double removal of thread 

    - happens when removing a running thread (thread_detachInstance) that
  gets removed again at the end of thread_entryPoint
- fixed by setting .prev/.next to null on removal and checking for that
- requires the obvious care when removing threads while looping over the list
- also helps the GC a bit to collect dead Thread objects
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    be0c48e View commit details
    Browse the repository at this point in the history

  3. fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply 

    - fix a deadlock caused by lock order inversion
- must not use the GC while holding slock
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    d56a259 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1421 from MartinNowak/fix15268 

    fix Issue 15268 - deadlock for Thread.getAll/Thread.opApply
    @dnadlinger
    dnadlinger committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    713aa05 View commit details
    Browse the repository at this point in the history
Loading