Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dlang/druntime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 713aa0568a0b
Choose a base ref
...
head repository: dlang/druntime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c2c255ce0be5
Choose a head ref
  • 4 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 31, 2015

  1. simplify handling of thread starts and GC suspend 

    - only keep threads in global thread list while they are running
  this directly avoids any issues with signals delivered during
  thread startup
- add an aboutToStart array to keep track of just spawned threads
  this is needed so that thread_joinAll doesn't miss a thread
  also the windows dll_attach_thread code looks up a just spawned thread
- remove all the misleading comments
- remove all the cargo cult handling of situations that can no longer
  occur, e.g. suspendDepth being set while adding a thread
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    7ec6520 View commit details
    Browse the repository at this point in the history

  2. fix Issue 15270 - use TLS to store Thread.getThis 

    - as signals are no longer send during thread startup we can use
  a TLS variable to store Thread.getThis()
- make sure to set the variable (and probably trigger lazy TLS
  allocation) before adding the Thread to the global list
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    e226ff2 View commit details
    Browse the repository at this point in the history

  3. fix race condition on m_addr 

    - between pthread_create(&m_addr) and reading m_addr to
  asserting isRunning when adding the newly created thread
- this race existed before but didn't manifest b/c the thread was added
  by the starting thread (after pthread_create) returned
- check isRunning after acquiring slock to ensure pthread_create already
  returned
    @MartinNowak
    MartinNowak committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    20f0350 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1422 from MartinNowak/fix15670 

    fix Issue 15270 - use TLS to store Thread.getThis
    @dnadlinger
    dnadlinger committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    c2c255c View commit details
    Browse the repository at this point in the history
Loading