Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dlang/druntime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8ddfb8dd711c
Choose a base ref
...
head repository: dlang/druntime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: df4d91295907
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 10, 2015

  1. Treat division by 0 as an error in Duration and consolidate code.

    Duration should never have checked for division by 0 and thrown a
    TimeException when it occurred. The OS/hardware already checks for that,
    and it should be considered a logic error. Checking for it and possibly
    throwing just slows the code down and makes it so that it can't be @nogc.
    
    This is technically a breaking change, but it will only break code which
    doesn't bother to avoid dividing by 0 and then catches TimeException
    when it occurs, and such code is likely extremely rare, if it exists at
    all. Given the fact that the odds of actually breaking code are
    extremely low and that this allows us to make Duration fully @nogc except
    for toString, I think that it's worth the risk.
    jmdavis committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    1a9e809 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2015

  1. Merge pull request #1405 from jmdavis/time

    Treat division by 0 as an error in Duration and consolidate code.
    MartinNowak committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    df4d912 View commit details
    Browse the repository at this point in the history
Loading