This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix unittest in core.thread #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Nov 11, 2014
Fix unittest in core.thread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unittest crashed/asserted for me this morning: it tries to detach a thread that might not have been initialized properly yet. In my case, the thread was not yet added to the thread list (this is done in the new thread itself), but remove is called by thread_detachInstance.
This could also be considered a bug in the synchronization on the thread list, but it is dubious to detach a thread that isn't fully initialized anyway. You could have created a OS thread in that case to start with.