This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Preparation for the issue 13701 - fix AA.dup for const elements #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2014
|
This PR should be merged in the 2nd of the three PRs (dlang/dmd#4154, #1031, dlang/dmd#4148). |
|
Auto-merge toggled on |
|
Thanks! |
MartinNowak
added a commit
that referenced
this pull request
Nov 21, 2014
Preparation for the issue 13701 - fix AA.dup for const elements
| @@ -365,16 +365,16 @@ extern (C) | |||
| // from druntime/src/rt/aaA.d | |||
|
|
|||
| // size_t _aaLen(in void* p) pure nothrow @nogc; | |||
| // void* _aaGetX(void** pp, const TypeInfo keyti, in size_t valuesize, in void* pkey); | |||
| private void* _aaGetX(void** paa, const TypeInfo keyti, in size_t valuesize, in void* pkey) pure nothrow; | |||
There was a problem hiding this comment.
How did that slipped through, _aaGetX is neither pure nor nothrow because it has to call TypeInfo.getHash and TypeInfo.equals which in turn might call any user defined function.
There was a problem hiding this comment.
Currentry the purity and nothrowness of toHash is just ignored on the AA assignment aa[key] = val;. It should go a searated issue.
|
This pull request introduced a regression: |
|
According to Martin Krejcirik, this pull request introduced a regression: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: dlang/dmd#4148
After fixing issue 13701,
aa[k] = v;will be rejected if the element of theaais not mutable. Therefore it should be improved before the compiler fix.Note that, the improved
dupis not CTFEable. To keepaa.dupworkable in CTFE, the CTFE interpreter in the compiler should handleaa.dupspecially.