This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 14863 - CLOCK_BOOTTIME should be optional to support <2.6.39 kernels #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx |
MartinNowak
added a commit
that referenced
this pull request
Aug 3, 2015
Fix issue 14863 - CLOCK_BOOTTIME should be optional to support <2.6.39 kernels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14863
I realized, MonoTime.currTime is already checking for 0 and asserting (and any use of 0 for ticksPerSecond will have a divide by zero error anyway), we should simply defer to that. I made a note in the code so people don't add the asserts back in later.
This still doesn't eliminate a segfault for anyone who actually uses CLOCK_BOOTTIME on an unsupported system, since assert(0) turns into halt statement, but that is really a separate issue.