More extensive ioctl support for OSX #1485
Conversation
| @@ -323,13 +323,7 @@ else version (OSX) | |||
| import core.sys.posix.termios; // termios | |||
| import core.sys.posix.sys.time; // timeval | |||
|
|
|||
| struct winsize | |||
There was a problem hiding this comment.
Where is winsize defined now for non-OSX posixes?
There was a problem hiding this comment.
Not sure what you mean -- I only moved the 'struct winsize' from the version (OSX) block into ttycom.d. This is to reflect how it is placed in the C header files on OSX so someone moving to D from C on OSX knows where to look for this based on C documentation.
There was a problem hiding this comment.
oh, I see what you mean, I didn't realize the context of the file in the diff. cool.
There was a problem hiding this comment.
I will move winsize back into ioctl.d. Even though I decided to follow the OSX header file model (and I will for the remaining things if there are no objections), I realized there may be existing D programs that include only ioctl.d and would have expected winsize to be present in ioctl.d itself (i.e for backwards compatibility).
There was a problem hiding this comment.
Instead of getting winsize back into ioctl.d, I reverted to your original suggestion and made the ttycom and filio imports public. This way, now people can simply include ioctl module and don't need to include the additional ttycom and filio modules. This avoids having to include ioctl in ttycom module, but also keeps the separation of definitions like in the C headers.
There was a problem hiding this comment.
On Sun, Jan 31, 2016 at 07:39:35PM -0800, sanjayss wrote:
Instead of getting winsize back into ioctl.d, I reverted to our original suggestion and made the ttycom and filio imports public. This way, now people can simply include ioctl module and don't need to include the additional ttycom and filio modules. This avoids having to include ioctl in ttycom module, but also keeps the separation of definitions like in the C headers.
Cool, I think that will please everyone.
…ceed." This reverts commit e4eb392.
|
What's the state of this? @adamdruppe |
|
If the question was directed to me -- there is nothing more to add or On Fri, Apr 1, 2016 at 6:03 AM, Dmitry Olshansky notifications@github.com
|
|
Auto-merge toggled on |
I followed the .h structure on OSX and split the ioctl functionality into ioccom.d (for some basic macros), ttycom.d (that separates out terminal functionality) and filio.d (which has some file related ioctl commands).