Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

netbsd patch: core/sys/posix #1494

Merged
merged 1 commit into from
Mar 15, 2017
Merged

netbsd patch: core/sys/posix #1494

merged 1 commit into from
Mar 15, 2017

Conversation

sibnick
Copy link
Contributor

@sibnick sibnick commented Feb 4, 2016

A part of NetBSD support (joakim-noah suggests to split original big pull request)

@sibnick sibnick mentioned this pull request Feb 4, 2016
Merged
ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/arpa/inet.d Outdated
int inet_pton(int, in char*, void*);
}

else version( Solaris )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also added a solaris path here. :-)

ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/dirent.d Outdated
else
{
DIR* opendir(in char*);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual penance if you discover a discrepancy on one platform is to write a version block for each known tested platform, using static assert (0) for the else branch.

This alerts the next person who will port this code to go check and verify that it's defined properly.

@sibnick
Copy link
Contributor Author

sibnick commented Feb 4, 2016

to ibuclaw : fixed (remove solaris duplicate block)

ibuclaw
ibuclaw reviewed Feb 4, 2016
View reviewed changes
src/core/sys/posix/arpa/inet.d Outdated
@@ -124,6 +124,31 @@ else version( FreeBSD )
const(char)* inet_ntop(int, in void*, char*, socklen_t);
int inet_pton(int, in char*, void*);
}
else version( NetBSD )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that druntime is inconsistent everywhere about this. But I'd rather all new code follow the same (standard?) convention for version statements.

else version (NetBSD)
{

@joakim-noah
Copy link
Contributor

Skimmed just to make sure all changes are isolated to version(NetBSD) blocks, looks good on that front.

@sibnick
Copy link
Contributor Author

sibnick commented Feb 4, 2016

replace version( NetBSD ) with version(NetBSD)
remove blank lines
dirent.d : add version block for each known tested platform, using static assert (0) for the else branch

@sibnick sibnick force-pushed the netbsd_core_sys_posix branch 3 times, most recently from 4a9ff40 to 95459fc Compare March 8, 2016 12:44
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request head (netbsd_core_sys_posix@a21504b).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bf08d...a21504b. Read the comment docs.

@ibuclaw
Copy link
Member

ibuclaw commented Feb 13, 2017

Looks like you missed one blank line. Other than that looks ok to me.

@sibnick
Copy link
Contributor Author

sibnick commented Feb 13, 2017 •
edited
Loading

Iain
Are you talking about last empty line in termios.d?

I added empty line to termios.d and remove one blank line in poll.d

@ibuclaw
Copy link
Member

ibuclaw commented Feb 14, 2017

@nrTQgc - there was a comment from @joakim-noah that was listed as not updated last time I looked. I can't see it now so I guess all is OK.

joakim-noah
joakim-noah suggested changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@joakim-noah joakim-noah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed to make sure changes are encapsulated and for formatting: once these changes are made, can approve.

src/core/sys/posix/pthread.d Outdated
enum PTHREAD_COND_INITIALIZER = pthread_cond_t(0x55550005);
enum PTHREAD_RWLOCK_INITIALIZER = pthread_rwlock_t(0x99990009);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

src/core/sys/posix/signal.d Outdated
int sa_flags;
}
}
else version(NetBSD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OpenBSD

src/core/sys/posix/signal.d Outdated
int sigpause(int);
int sigrelse(int);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank line

@sibnick
Copy link
Contributor Author

sibnick commented Mar 15, 2017

joakim-noah - I fixed you issues

@dnadlinger
Copy link
Member

Merging as it has been okay'd by two reviewers.

@dlang-bot dlang-bot merged commit be8b8ea into dlang:master Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joakim-noah joakim-noah joakim-noah requested changes

@ibuclaw ibuclaw ibuclaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sibnick @joakim-noah @codecov-io @ibuclaw @dnadlinger @dlang-bot