This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
add @nogc to bytesHash #1624
Merged
add @nogc to bytesHash #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
Current coverage is 73.93% (diff: 100%)@@ master #1624 diff @@
==========================================
Files 133 133
Lines 16980 16980
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 12555 12555
Misses 4425 4425
Partials 0 0
|
| size_t bytesHash(const(void)* buf, size_t len, size_t seed = 0) | ||
| { | ||
| static uint rotl32(uint n)(in uint x) pure nothrow @safe | ||
| static uint rotl32(uint n)(in uint x) pure nothrow @safe @nogc |
There was a problem hiding this comment.
this function already exists in std.core.bitop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://forum.dlang.org/post/gmeowrdivjpjhezbdror@forum.dlang.org.
By the way,
bytesHashshould not be@trusted. It takes pointer and length separately.