This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
[REG2.068] Fix Issue 16974 - Equal associative arrays with associative array keys are considered unequal #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-sh
force-pushed
the
fix-Issue-16974
branch
from
1e39f02 to
32de26d
Compare
|
Since this is a regression could you change the branch to |
denis-sh
changed the title
…s are considered unequal Use correct overload of `hashOf` in `_aaGetHash`. This incorrect usage is possible because of Issue 16973 - `hashOf` has error-prone signature as `(T, seed)` may be confused with `(ptr, length)` [1]. [1] https://issues.dlang.org/show_bug.cgi?id=16973
denis-sh
force-pushed
the
fix-Issue-16974
branch
from
32de26d to
5cc2843
Compare
|
Unrelated failure in phobos, fixed in |
tramker
pushed a commit
to tramker/druntime
that referenced
this pull request
Dec 28, 2016
[REG2.068] Fix Issue 16974 - Equal associative arrays with associative array keys are considered unequal Signed-off-by: Martin Krejcirik <mk@krej.cz> Conflicts: src/rt/aaA.d
kinke
pushed a commit
to kinke/druntime
that referenced
this pull request
Jan 15, 2017
Tackle issue dlang#1715 (force-inline intrinsic shims)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct overload of
hashOfin_aaGetHash.This incorrect usage is possible because of Issue 16973 -
hashOfhas error-prone signature as(T, seed)may be confused with(ptr, length).