Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

scan DATA and TLS according to compiler generated pointer infos #1763

Merged
merged 4 commits into from
Feb 18, 2017

Conversation

rainers
Copy link
Member

@rainers rainers commented Feb 12, 2017

Implement precise scanning of the DATA and TLS segment for Win32, based on pointer information written by dlang/dmd#6534

@MartinNowak
Copy link
Member

I guess we might regret it once looking at DLLs again, but let's try it as experiment.
Can you (or someone else) gather non-trivial benchmarks?

@MartinNowak
Copy link
Member

Auto-merge toggled on

@rainers
Copy link
Member Author

rainers commented Feb 18, 2017

Thanks. I use this in the Visual D build (a DLL, but not sharing phobos), the map file shows that the number of pointers is similar to phobos unittest (357 data, 246 tls), but in about 800 kB.

@MartinNowak
Copy link
Member

Thanks. I use this in the Visual D build (a DLL, but not sharing phobos), the map file shows that the number of pointers is similar to phobos unittest (357 data, 246 tls), but in about 800 kB.

Does it measurably speed up scanning?

@MartinNowak
Copy link
Member

Still seems to fail.

@rainers
Copy link
Member Author

rainers commented Feb 18, 2017

Does it measurably speed up scanning?

I don't have any benchmarks on that. My concern in Visual D is editing files like std.datetime eating memory like crazy.

@rainers
Copy link
Member Author

rainers commented Feb 18, 2017

Still seems to fail.

Seems to crash for Win64. That works for me locally.

@rainers
Copy link
Member Author

rainers commented Feb 18, 2017

I'm going to disable the precise scanning for now. Should we make enabling precise DATA/TLS scanning a DRT-option?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants