Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fix issue 5689 #180

Merged
merged 2 commits into from
Mar 21, 2012
Merged

fix issue 5689 #180

merged 2 commits into from
Mar 21, 2012

Conversation

MartinNowak
Copy link
Member

  • save XMM arguments and return values in trace_pro/epi
  • trace uses memcmp which clobbers XMM regs on linux

fix issue 5689
7c4a80b 
- save XMM arguments and return value in trace_pro/epi
@braddr
Copy link
Member

braddr commented Mar 20, 2012

walter added xmm support for osx/32 (which ought to be extended to the other platforms at some point too). So that branch of the code needs it. Do you have a test case for this bug that can be added to the test suite?

@MartinNowak MartinNowak mentioned this pull request Mar 20, 2012
Merged
@MartinNowak
Copy link
Member Author

The OSX IA-32 ABI says that only __vector should be passed in XMM regs. DMD doesn't do that at the moment but it's probably better to simply save them.

WalterBright added a commit that referenced this pull request Mar 21, 2012
@WalterBright
Merge pull request #180 from dawgfoto/fix5689
c7dc74a 
fix issue 5689
@WalterBright WalterBright merged commit c7dc74a into dlang:master Mar 21, 2012
@WalterBright
Copy link
Member

This completely fails on 32 bit builds. Please test before submitting.

@MartinNowak
Copy link
Member Author

fixup #184

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinNowak @braddr @WalterBright