Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Implement druntime functions for allocating individual structs on the heap. #202

Merged
merged 2 commits into from
May 11, 2012

Conversation

schveiguy
Copy link
Member

Filled out stub functions for _d_newitemT and _d_newitemiT. I noticed the typeinfo passed to these functions is still the "array of" typeinfo, but that is not a huge deal. However, it seems a little odd.

fix issue 7243 - Compiler should call separate function when allocating a struct on the heap

@dnadlinger
Copy link
Member

Ping? Looks fine to me, the only thing I might change is to remove the pieces of code for the 0 size case, which are commented out anyway (OTOH, I'm not sure if they could ever be triggered, though).

@schveiguy
Copy link
Member Author

I was waiting to hear back on pull request 556 for phobos

regarding the 0 size case, I wasn't sure if it was valid to receive a 0 size. For the array case, a 0 length was certainly possible. But a 0 size, I'm not sure.

And yeah, it's commented out, but I don't know if it will break anything when it's checked in :) I say leave it commented out, and then if nobody complains for a couple months, we can remove the comments.

@schveiguy
Copy link
Member Author

Seems like this should be merged then, 556 was merged. I'll merge this and close the bugzilla issue.

It's failing freebsd, but so is everything else, looks like an error in the main line.

schveiguy added a commit that referenced this pull request May 11, 2012
Implement druntime functions for allocating individual structs on the heap.
@schveiguy schveiguy merged commit 7375e90 into dlang:master May 11, 2012
@schveiguy schveiguy deleted the issue7243 branch February 10, 2015 17:11
JohanEngelen pushed a commit to weka/druntime that referenced this pull request Mar 7, 2022
This is needed to build on OpenBSD.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants