Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Merge all cpp sources #2259

Closed
wants to merge 1 commit into from
Closed

Conversation

TurkeyMan
Copy link
Contributor

Merged cpp source into one file as per @WalterBright's recommendations for correct usage of extern(C++).

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2259"

@dnadlinger
Copy link
Member

(Sorry, on mobile…)

@JinShil
Copy link
Contributor

JinShil commented Jul 31, 2018

See https://forum.dlang.org/post/mailman.2861.1532969129.29801.digitalmars-d@puremagic.com for context ;-)

@Geod24
Copy link
Member

Geod24 commented Jul 31, 2018

Uh, that is obviously going to scale very well /s
Thanks for the context @JinShil

@jmdavis
Copy link
Member

jmdavis commented Jul 31, 2018

sigh I don't see how stuffing all of C++'s std in a single file is going to be anything other than an unmaintainable mess. There isn't a lot of code here right now, but if we ever end up with much of the STL and whatnot in druntime, then this file will become so huge that it would be insane. If the "correct" usage of extern(C++) involves shoving entire namespaces in a single file, then we're doing something very wrong.

@TurkeyMan
Copy link
Contributor Author

sigh I don't see how stuffing all of C++'s std in a single file is going to be anything other than an unmaintainable mess. [...]

I know, right...

@TurkeyMan TurkeyMan closed this Aug 1, 2018
@TurkeyMan TurkeyMan deleted the stdcpp_fixes branch August 5, 2018 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants