Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

FIX Issue 19643 - add missing Objective-C function calling convention #2482

Closed
wants to merge 1 commit into from
Closed

FIX Issue 19643 - add missing Objective-C function calling convention #2482

wants to merge 1 commit into from

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Feb 4, 2019

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 4, 2019

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19643 minor core.demangle doesn't handle extern(Objective-C) correctly

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2482"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Feb 4, 2019
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @jacob-carlborg

src/core/demangle.d Outdated Show resolved Hide resolved
@rainers
Copy link
Member

rainers commented Feb 4, 2019

The mangling for Objective-C has an ambiguity if used with the grammar from the website, see https://issues.dlang.org/show_bug.cgi?id=17310. IIRC the demangler should be able to handle these nevertheless, but you might want to add some symbols from that bug report to the tests, too.

@dlang-bot dlang-bot added stalled and removed stalled labels Oct 3, 2021
@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed Needs Work labels Oct 21, 2021
@dlang-bot dlang-bot added stalled and removed Needs Work Needs Rebase needs a `git rebase` performed stalled labels Apr 20, 2022
@kubo39 kubo39 closed this by deleting the head repository Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants