Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19796 - wrong assumption of integral element type #2550

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@wilzbach
Copy link
Member

commented Apr 9, 2019

I didn't know any better way to do this, so better ideas are very welcome!

@wilzbach wilzbach requested review from MartinNowak and schveiguy as code owners Apr 9, 2019

@dlang-bot

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Severity Description
19796 regression druntime PR#1982 broke array ops on double[] due to wrong assumption of integral element type

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2550"
@wilzbach

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Regression or critical bug fixes should always target the stable branch.

Regression is in master only.

@dlang-bot dlang-bot merged commit 27a9ac2 into dlang:master Apr 9, 2019

6 checks passed

CyberShadow/DAutoTest Documentation OK (no changes)
Details
auto-tester Pass: 10
Details
buildkite/druntime Build #1511 passed (36 minutes, 43 seconds)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
codecov/patch 71.428% of diff hit (target 73.916%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@quickfur

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.