Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fixed the cas function not returning the result #2733

Merged
merged 1 commit into from Aug 13, 2019

Conversation

TurkeyMan
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20122 enhancement core.atomic.cas discards result on failure

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2733"

@dlang-bot dlang-bot added the Enhancement New functionality label Aug 13, 2019
Added overloads that return the result.
@dlang-bot dlang-bot merged commit 7b3cc86 into dlang:master Aug 13, 2019
@TurkeyMan TurkeyMan deleted the cas_overloads branch August 14, 2019 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New functionality
Projects
None yet
3 participants