Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20346 - std.uuid does not compile with checkaction=context #2846

Merged
merged 2 commits into from Nov 3, 2019

Conversation

MoonlightSentinel
Copy link
Contributor

Marking all parameters as const additionally reduces the amount of instantiations of miniFormat

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20346 normal std.uuid does not compile with checkaction=context

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2846"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Nov 1, 2019
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Though we should check the actual generated string.

test/exceptions/src/assert_fail.d Outdated Show resolved Hide resolved
@MoonlightSentinel
Copy link
Contributor Author

@wilzbach Dont merge yet, i will add another test concerning the correct toString selection

@MoonlightSentinel MoonlightSentinel force-pushed the checkaction-enums branch 2 times, most recently from 4723733 to 6cca8a0 Compare November 2, 2019 11:58
@MoonlightSentinel
Copy link
Contributor Author

@wilzbach Done

@PetarKirov PetarKirov merged commit 4eff6db into dlang:master Nov 3, 2019
@MoonlightSentinel MoonlightSentinel deleted the checkaction-enums branch January 14, 2020 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
4 participants