This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
core.math: Add templated toPrec. #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2864" |
This was referenced Dec 10, 2019
| * f in precision of type `T` | ||
| */ | ||
| @safe pure nothrow | ||
| T toPrec(T:float)(float f) { pragma(inline, false); return f; } |
There was a problem hiding this comment.
Why pragma(inline, false);?
There was a problem hiding this comment.
I would assume just in case the inliner removes the call before builtins handler is given a chance to expand it.
There was a problem hiding this comment.
I'm worried about performance, but I suppose if this is a CTFE only intrinsic then there is no problem.
Some floating point algorithms, such as Kahan-Babuska-Neumaier Summation, require rounding to specific precisions. Rounding to precision after every operation, however, loses overall precision in the general case and is a runtime performance problem. Adding these functions guarantee the rounding at required points in the code, and document where in the algorithm the requirement exists.
|
Disabling problematic tests until compiler support has been added. |
thewilsonator
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some floating point algorithms, such as Kahan-Babuska-Neumaier Summation,
require rounding to specific precisions. Rounding to precision after
every operation, however, loses overall precision in the general case
and is a runtime performance problem.
Adding these functions guarantee the rounding at required points in the
code, and document where in the algorithm the requirement exists.
Rebase of #1941.