This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Switch default behavior of tests to only run tests when they are present #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
present. main will only be run if there are no unit tests.
schveiguy
requested review from
andralex,
MartinNowak and
wilzbach
as code owners
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2877" |
thewilsonator
approved these changes
Dec 18, 2019
Geod24
approved these changes
Dec 18, 2019
|
This caused a regression on dlang-tour: https://issues.dlang.org/show_bug.cgi?id=20500 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been done a long time ago, but I forgot about it. The note said it would be switched by 2.080, but we are pushing 2.090 next...
The new default behavior makes it so any unittests present will cancel the running of main, even on a successful test run. The old behavior can be had by passing in a DRT switch (see changelog notes).