Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 15322 - Correct versioning PENUM_PAGE_FILE_CALLBACK #2928

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Fix Issue 15322 - Correct versioning PENUM_PAGE_FILE_CALLBACK #2928

merged 2 commits into from
Feb 6, 2020

Conversation

Chigusa0w0
Copy link
Contributor

@Chigusa0w0 Chigusa0w0 commented Feb 4, 2020 •
edited
Loading

Correct versioning PENUM_PAGE_FILE_CALLBACK

@Chigusa0w0
Fix Issue 15322 - Correct versioning PENUM_PAGE_FILE_CALLBACK
5155003 
According to [Microsoft Docs](https://docs.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-enumpagefilesw), `EnumPageFilesW` always taking a `PENUM_PAGE_FILE_CALLBACKW` parameter. While before the correction, when version `Unicode` is not defined, `EnumPageFilesW` will be declared to take a `PENUM_PAGE_FILE_CALLBACKW`.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @LimiQS! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 15322 normal version(Unicode) should affect only default aliases

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2928"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Feb 4, 2020
CyberShadow
CyberShadow suggested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but why remove the PENUM_PAGE_FILE_CALLBACK alias?

@Chigusa0w0
Copy link
Contributor Author

OK, but why remove the PENUM_PAGE_FILE_CALLBACK alias?

Sorry I missed that. Has been fixed.

@CyberShadow
Copy link
Member

Nit, commit messages ought to be wrapped to 80 characters, and are in plain text (not Markdown).

@Chigusa0w0
Copy link
Contributor Author

Nit, commit messages ought to be wrapped to 80 characters, and are in plain text (not Markdown).

Ok, I will follow this standard.

@kubo39
Copy link
Contributor

kubo39 commented Feb 4, 2020

Why not stable?

@thewilsonator
Copy link
Contributor

@LimiQS your repository seems to have gone missing?

@kubo39
Copy link
Contributor

kubo39 commented Feb 4, 2020

@thewilsonator https://github.com/LimiQS/druntime/tree/patch-1 perhaps already restored, needs re-running auto-tester?

@thewilsonator
Copy link
Contributor

Well Github says "Unknown repository".

@kubo39
Copy link
Contributor

kubo39 commented Feb 4, 2020 •
edited
Loading

Hmm, yes, GitHub points to https://github.com/dlang/druntime/tree/patch-1, maybe GitHub's bug...?

@Chigusa0w0
Copy link
Contributor Author

It was missing, I restored branch manually.

@dlang-bot dlang-bot merged commit 51841bc into dlang:master Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@CyberShadow CyberShadow CyberShadow approved these changes

Assignees
No one assigned
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Chigusa0w0 @dlang-bot @CyberShadow @kubo39 @thewilsonator