Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20629 - atomicStore does not compile for struct using -m64 #2971

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 3, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20629 normal atomicStore does not compile for struct using -m64

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#2971"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Mar 3, 2020
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a regression. Please target stable.

@MoonlightSentinel
Copy link
Contributor Author

This is a regression. Please target stable.

Sorry, I'll rebase once the CI is done.

@thewilsonator
Copy link
Contributor

The rebase will restart the CI anyway, you may as well change it now.

@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable March 3, 2020 11:23
@MoonlightSentinel
Copy link
Contributor Author

Done

@thewilsonator
Copy link
Contributor

Thanks!

@MoonlightSentinel
Copy link
Contributor Author

auto-merge won't work because #2970 is not in stable yet.

Question from the newsgroup:
Will this be included in the new release?

@thewilsonator
Copy link
Contributor

Yes.

@dlang-bot dlang-bot merged commit c976229 into dlang:stable Mar 3, 2020
@MoonlightSentinel MoonlightSentinel deleted the atomic-struct branch March 3, 2020 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants