Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20640 - LDC: AddressSanitizer failing to catch SIGSEGV in unittest #2977

Closed
wants to merge 1 commit into from
Closed

Fix Issue 20640 - LDC: AddressSanitizer failing to catch SIGSEGV in unittest #2977

wants to merge 1 commit into from

Conversation

kubo39
Copy link
Contributor

@kubo39 kubo39 commented Mar 6, 2020

Stop overriding SIGSEGV/SIGBUS handlers if already exists.

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 3, 2021

Thanks for your pull request and interest in making D better, @kubo39! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20640 normal LDC: AddressSnitizer failing to catch SIGSEGV in unittest

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#2977"

@dlang-bot dlang-bot added Bug Fix Include reference to corresponding bugzilla issue Enhancement New functionality labels Oct 3, 2021
unittest

Stop overriding SIGSEGV/SIGBUS handlers if already exists.
@RazvanN7
Copy link
Contributor

RazvanN7 commented Dec 7, 2021

@kubo39 what is the status of this PR?

@kubo39
Copy link
Contributor Author

kubo39 commented Jan 24, 2022

ah, sorry for late response and ok to close this.

@kubo39 kubo39 deleted the fix-issue20640 branch January 24, 2022 01:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue Enhancement New functionality Needs Work stable-stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants