Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20748 - Deprecation for assert using shared type and checka… #3044

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

…ction=context

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 19, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20748 regression Deprecation for assert using shared type and checkaction=context

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3044"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 19, 2020
@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable April 19, 2020 10:03
@dlang-bot dlang-bot merged commit 7bfd504 into dlang:stable Apr 19, 2020
@MoonlightSentinel MoonlightSentinel deleted the shared-assert branch April 19, 2020 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants