Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] Backport PPC fixes #3083

Merged
merged 3 commits into from Apr 30, 2020
Merged

[dmd-cxx] Backport PPC fixes #3083

merged 3 commits into from Apr 30, 2020

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Apr 30, 2020

No description provided.

ibuclaw added 3 commits Apr 29, 2020
The default initialized hard limit is pulled from sysconf(_SC_PAGESIZE),
however this varies from platform to platform.  On one x86_64-linux
server, the value is 4096, whilst on another powerpc64le-linux server,
it is 65536.  It is for the latter PPC server, that the test failed,
because the Fiber stack is never overflowed.
There is no toPrec intrinsic for imaginary types, so must use .im to
convert to real as needed.
@dlang-bot
Copy link
Contributor

@dlang-bot dlang-bot commented Apr 30, 2020

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "dmd-cxx + druntime#3083"
@ibuclaw ibuclaw added the Bug Fix label Apr 30, 2020
@ibuclaw ibuclaw changed the title [dmd-cxx] Backport PPC and SPARC fixes [dmd-cxx] Backport PPC and fixes Apr 30, 2020
@ibuclaw ibuclaw changed the title [dmd-cxx] Backport PPC and fixes [dmd-cxx] Backport PPC fixes Apr 30, 2020
@ibuclaw
Copy link
Member Author

@ibuclaw ibuclaw commented Apr 30, 2020

Bootstrapped and regression tested on powerpc64le-linux-gnu.

Native configuration is powerpc64le-unknown-linux-gnu

		=== gdc tests ===

Schedule of variations:
    unix

Running target unix
Running /build/gcc/testsuite/gdc.dg/asan/asan.exp ...
Running /build/gcc/testsuite/gdc.dg/dg.exp ...
Running /build/gcc/testsuite/gdc.dg/lto/lto.exp ...
Running /build/gcc/testsuite/gdc.dg/ubsan/ubsan.exp ...
Running /build/gcc/testsuite/gdc.test/compilable/compilable.exp ...
Running /build/gcc/testsuite/gdc.test/fail_compilation/fail_compilation.exp ...
Running /build/gcc/testsuite/gdc.test/runnable/runnable.exp ...
Running /build/gcc/testsuite/gdc.test/runnable_cxx/runnable_cxx.exp ...

		=== gdc Summary ===

# of expected passes		28974
# of unsupported tests		825

		=== libphobos tests ===

Schedule of variations:
    unix

Running target unix
Running /build/libphobos/testsuite/libphobos.aa/aa.exp ...
Running /build/libphobos/testsuite/libphobos.allocations/allocations.exp ...
Running /build/libphobos/testsuite/libphobos.cycles/cycles.exp ...
Running /build/libphobos/testsuite/libphobos.druntime/druntime.exp ...
Running /build/libphobos/testsuite/libphobos.druntime_shared/druntime_shared.exp ...
Running /build/libphobos/testsuite/libphobos.exceptions/exceptions.exp ...
Running /build/libphobos/testsuite/libphobos.hash/hash.exp ...
Running /build/libphobos/testsuite/libphobos.init_fini/init_fini.exp ...
Running /build/libphobos/testsuite/libphobos.phobos/phobos.exp ...
Running /build/libphobos/testsuite/libphobos.phobos_shared/phobos_shared.exp ...
Running /build/libphobos/testsuite/libphobos.shared/shared.exp ...
Running /build/libphobos/testsuite/libphobos.thread/thread.exp ...
Running /build/libphobos/testsuite/libphobos.typeinfo/typeinfo.exp ...

		=== libphobos Summary ===

# of expected passes		296
@ibuclaw ibuclaw merged commit 7bdd83d into dlang:dmd-cxx Apr 30, 2020
2 of 3 checks passed
2 of 3 checks passed
auto-tester Pass: 7, Fail: 2, Pending: 1
Details
buildkite/druntime Build #3766 passed (11 seconds)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@ibuclaw ibuclaw deleted the ibuclaw:dmd-cxx-ppc branch Apr 30, 2020
farazs-github pushed a commit to MIPS/gcc that referenced this pull request Apr 30, 2020
Corrects a previous change made to the SPARC stdc bindings, and
backports PPC-related fixes.  The library and language testsuite now
passes fully on powerpc64le-linux-gnu.

Fixes: PR d/90719
Fixes: PR d/94825

Reviewed-on: dlang/dmd#11079
	     dlang/druntime#3078
	     dlang/druntime#3083

libphobos/ChangeLog:

	PR d/94825
	* libdruntime/Makefile.am (DRUNTIME_SOURCES_CONFIGURED): Remove
	config/powerpc/switchcontext.S
	* libdruntime/Makefile.in: Regenerate.
	* libdruntime/config/powerpc/callwithstack.S: Remove.
	* libdruntime/config/powerpc/switchcontext.S: Fix symbol name of
	fiber_switchContext.
	* libdruntime/core/thread.d: Disable fiber migration tests on PPC.
	* testsuite/libphobos.thread/fiber_guard_page.d: Set guardPageSize
	same as stackSize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants