This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
[dmd-cxx] fix Issue 19861 - core.cpuid reports the wrong number of threads #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not use i7 detection on AMD processors use cpuid 0x8000_001E to detect the number of threads per core
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + druntime#3107" |
|
Bootstrapped, running regression tests... |
|
Not backporting the tests ? |
|
What tests? |
It's just a bunch of printfs, nothing is actually checked. So I don't honestly see the point of it. |
|
Regression tests ran, no reported failures. |
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
May 17, 2020
- core.cpuid has been fixed to not use i7 detection on AMD processors.
- std.net.curl has been fixed to correctly handle HTTP/2 status lines.
- std.zip has had a test fixed to not rely on unzip being installed.
Fixes: PR d/95166
PR d/95167
PR d/95168
Reviewed-on: dlang/druntime#3107
dlang/phobos#7486
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from #2620