Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 20910: fix misleading unittest runner messages. #3129

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

quickfur
Copy link
Member

@quickfur quickfur commented Jun 9, 2020

The number returned by runModuleUnitTests is not the number of unittests, but the number of modules tested.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 9, 2020

Thanks for your pull request, @quickfur!

Bugzilla references

Auto-close Bugzilla Severity Description
20910 normal Default unittest runner reports wrong unittest count

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3129"

@thewilsonator
Copy link
Contributor

Please rebase this PR onto dlang/master's HEAD and the errors should do away.

@thewilsonator
Copy link
Contributor

Also please prepend Fix to the front of the commit message so the bot closes the issue. Feel free to add auto merge yourself once this passes.

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jun 9, 2020
@quickfur
Copy link
Member Author

quickfur commented Jun 9, 2020

I'm already working off HEAD. No idea what the problem might be.

@wilzbach
Copy link
Member

wilzbach commented Jun 9, 2020

No idea what the problem might be.

Druntime's testsuite is failing. Is it passing for you locally?
There are tests which grep for the previous output, e.g.

test -z "FAILED" || grep -q "unittests FAILED" generated/linux/release/32/badn.done
/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/dmd/generated/linux/release/32/dmd -m32  -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -L-lpthread -L-lm -L/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/druntime/generated/linux/release/32/libdruntime.a -O -release -version=_GLIBCXX_USE_CXX98_ABI -main -unittest -version=CoreUnittest -c -of=./generated/linux/release/32/string_old_d.o src/string_test.d
/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/dmd/generated/linux/release/32/dmd -m32  -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -L-lpthread -L-lm -L/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/druntime/generated/linux/release/32/libdruntime.a -O -release -unittest -version=CoreUnittest -gx -ofgenerated/linux/release/32/precisegc ../../src/gc/impl/conservative/gc.d ../../src/rt/lifetime.d precisegc.d
Makefile:36: recipe for target 'generated/linux/release/32/badn.done' failed
make[2]: *** [generated/linux/release/32/badn.done] Error 1
/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/dmd/generated/linux/release/32/dmd -m32  -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -L-lpthread -L-lm -L/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/druntime/generated/linux/release/32/libdruntime.a -O -release -g -ofgenerated/linux/release/32/rt_trap_exceptions_drt src/rt_trap_exceptions_drt.d
test 1 -eq 1 || ! grep -q main generated/linux/release/32/na.done
test -z "" || grep -q "unittests " generated/linux/release/32/na.done
test -n "" || ! grep -q "unittests" generated/linux/release/32/na.done
make[2]: Leaving directory '/media/disk1/braddr/sandbox/at-client/pull-4078093-Linux_32/druntime/test/unittest'
posix.mak:339: recipe for target 'test/unittest/.run' failed

The number returned by runModuleUnitTests is not the number of tests,
but the number of modules tested.
@quickfur
Copy link
Member Author

@thewilsonator BTW, I don't think I have commit access to druntime.

@dlang-bot dlang-bot merged commit 67618bd into dlang:master Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants