-
-
Notifications
You must be signed in to change notification settings - Fork 421
Backport move(Emplace) fixes from Phobos #3133
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3133" |
| else | ||
| target = source; | ||
|
|
||
| static if (hasElaborateMove!T) | ||
| __move_post_blt(target, source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confess I didn't know this already exists. Good lord, another half-complete feature (copy ctors...), as the compiler AFAIK doesn't emit any calls for the (many) implicit moves...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't this __move_post_blt and opPostMove business become a non-starter due to qualifier hell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It certainly needs more work but the druntime/phobos versions of these functions shouldn't differ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just ping @RazvanN7 in hopes of clarifying the status of __move_post_blt. If it's dead, quite a few changes would need to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
I'd rather if this was looked over wrt __move_post_blt and the de-facto status of DIP1014. |
|
Ping, |
No description provided.