Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 21055 - core.stdc.stdarg is not nogc #3163

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 18, 2020

This is targeting master since there is a chance certain template instantiations break when forced @nogc. I hope the test suite covers stdarg well.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21055 normal core.stdc.stdarg is not @nogc

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3163"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jul 18, 2020
@thewilsonator thewilsonator added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Jul 18, 2020
@dkorpel
Copy link
Contributor Author

dkorpel commented Aug 4, 2020

It's green now

@wilzbach wilzbach merged commit 349d637 into dlang:master Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
72h no objection -> merge The PR will be merged if there are no objections raised. Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants