This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
merge stable #3315
Merged
merge stable #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t calling destroy and postblit of base type Also offTi but as that does not seem to be implemented yet mentioning it in the change log would be confusing.
This can easily lead to InvalidMemoryOperation (e.g. in Vibe.d).
Fix documentation of cas
…of a struct with a core.stdcpp.vector field is referenced before the struct's definition Related discussion at https://forum.dlang.org/thread/efjydhujahujqjrvmnsk@forum.dlang.org
Similar to the issue fixed here dlang#1655 (comment) , static version of the sections_elf_shared accesses TLS of a dead thread. The simplest fix is to allocate _tlsRanges somewhere that would persist outside of the thread scope, for example the C heap. This was encountered while porting ldc 1.24.0 to Alpine Linux which uses Musl. https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/14364 But this issue should be affecting other libc implementations as well.
…destruction to be `@nogc`
core.stdcpp.new_.cpp_delete unnecessarily requires destruction to be @nogc merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
…scope void*...) Those functions never worked, and would cause an infinite recursion. In a non-optimized build that would exhaust the stack and trigger a SEGV, however in the optimized build we distribute, it results in an infinite loop as tail call optimization is performed.
MartinNowak
requested review from
andralex,
Burgos,
ibuclaw,
TurkeyMan,
WalterBright and
wilzbach
as code owners
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3315" |
PetarKirov
approved these changes
Dec 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nogc