This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 14790: rt: cover: coverage merge should detect changed source code #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case was forgotten and not being tested and should be. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
|
Thanks for your pull request and interest in making D better, @ljmf00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3341" |
ljmf00
force-pushed
the
fix-merge-coverage
branch
from
f7222cd to
fbd188d
Compare
ljmf00
force-pushed
the
fix-merge-coverage
branch
from
fbd188d to
74e2094
Compare
|
buildkite is heisenberging ¯\_(ツ)_/¯ |
…ce code Merging different versions of the same source file could lead to mismatched covered lines if the source code actually changes. Changing the .lst file format will open a huge breaking change and rely on timestamps is impractical. As an alternative to this, we can deeply compare the source code with generated .lst which also has a copy of the original source code. Signed-off-by: Luís Ferreira <contact@lsferreira.net>
ljmf00
force-pushed
the
fix-merge-coverage
branch
from
74e2094 to
6c7dc69
Compare
|
cc @RazvanN7 can you help with this? |
thewilsonator
approved these changes
Jan 27, 2021
|
This causes a regression. Sometimes that corrupts the input lst. see https://issues.dlang.org/show_bug.cgi?id=21712. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging different versions of the same source file could lead to mismatched
covered lines if the source code actually changes. Changing the .lst file
format will open a huge breaking change and rely on timestamps is impractical.
As an alternative to this, we can deeply compare the source code with generated
.lst which also has a copy of the original source code.
Signed-off-by: Luís Ferreira contact@lsferreira.net