Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 21309 along with other dead links on dlang.org #3345

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Jan 25, 2021

Signed-off-by: Luís Ferreira contact@lsferreira.net


This PR regenerates mak/DOCS files, fix some wrong documentation on Params and Source sections.

Also, if someone knows a better approach for generating $(DOCDIR)/%.html : src/%.d $(DMD) makefile targets in a more generic way, would be cool. I don't know much about Makefile and I think that's kinda dirty, although this approach was already there.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 25, 2021

Thanks for your pull request and interest in making D better, @ljmf00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21309 regression Missing core.thread.threadbase documentation

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3345"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jan 25, 2021
@ljmf00
Copy link
Member Author

ljmf00 commented Jan 25, 2021

Is documentation issues part of regression severity?

Fix issue 21309 along with other dead links on dlang.org.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dlang-bot dlang-bot merged commit a897e9d into dlang:master Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants